#40: Refactor UI search box component#56
#40: Refactor UI search box component#56prashant67690 wants to merge 2 commits intodicedb:masterfrom
Conversation
|
@lucifercr07 can you review and merge this pr |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
KaviiSuri
left a comment
KaviiSuri
left a comment
There was a problem hiding this comment.
i'm getting this error when i test it out. seems like we are stuck in a render loop
|
@KaviiSuri this error is not caused by my pr there seems to someone else feature which has caused this you can check the issues tab some one has created this issue too to fix this you can view #54 |
|
@prashant67690 please resolve the conflicts |
| ))} | ||
| )) | ||
| ) : ( | ||
| <p className="text-lg font-semibold text-gray-500 mb-2"> |
There was a problem hiding this comment.
Can we center this vertically?
Got it, its solved on main now, please resolve conflicts |
prashant67690
force-pushed
the
fix/ui-changes
branch
from
a785e53 to
214df9b
Compare
|
@lucifercr07 @KaviiSuri resolved them please check |
|
Hey @prashant67690 , sorry for the delay, it seems like there are more conflicts, could you please check? Some of the issues might also be already solved on the master branch |
|
ya sure i will fix the conflicts and push the latest changes tomorrow @KaviiSuri thanks for the reminder |
3 participants
Closes: #40
Date: 07-10-2024
Completed all the ui fixes and attached the of the final results below for Each Tasks
Screenshots
Task 1
Task 2
Task 3